liran-funaro commented on a change in pull request #10625:
URL: https://github.com/apache/druid/pull/10625#discussion_r536983967
##########
File path:
server/src/main/java/org/apache/druid/segment/indexing/TuningConfig.java
##########
@@ -37,6 +37,7 @@
int DEFAULT_MAX_PARSE_EXCEPTIONS = Integer.MAX_VALUE;
int DEFAULT_MAX_SAVED_PARSE_EXCEPTIONS = 0;
int DEFAULT_MAX_ROWS_IN_MEMORY = 1_000_000;
+ int DEFAULT_MAX_MEMORY_PERCENTAGE_OF_JVM = 16;
Review comment:
I think `DEFAULT_MAX_MEMORY_PERCENTAGE_OF_JVM` should be a parameter of
the appendable index.
A different index, e.g., off-heap, can use up to half the off-heap memory by
default for example.
This can be implemented in `AppendableIndexSpec` as
`getDefaultMaxMemoryPercentage()`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
