capistrant commented on pull request #10667: URL: https://github.com/apache/druid/pull/10667#issuecomment-743433241
Converted this to draft temporarily as I think I actually identified an unrelated issue in the ITHadoopIndexTest that is unrelated to my PR, but can be fixed here regardless. https://github.com/apache/druid/pull/10219 introduced a change in the output of SegmentMetadataQuery, and the expected output for one of the tests did not get updated to reflect (https://github.com/apache/druid/blob/master/integration-tests/src/test/resources/hadoop/batch_hadoop_queries.json#L3) .... running locally to verify. before pushing commit and un-drafting this PR. missed it cuz I had ignored a few tests to speed up my local build times 🤦 ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
