abhishekagarwal87 commented on a change in pull request #10653:
URL: https://github.com/apache/druid/pull/10653#discussion_r544947257
##########
File path:
processing/src/main/java/org/apache/druid/query/groupby/epinephelinae/RowBasedGrouperHelper.java
##########
@@ -712,13 +712,13 @@ public InputRawSupplierColumnSelectorStrategy
makeColumnSelectorStrategy(
return new StringInputRawSupplierColumnSelectorStrategy();
case LONG:
return
(InputRawSupplierColumnSelectorStrategy<BaseLongColumnValueSelector>)
- columnSelector -> columnSelector::getLong;
+ columnSelector -> () -> columnSelector.isNull() ? null :
columnSelector.getLong();
Review comment:
FYI, this change could cause a dip in performance when columns are
actually strings and being read as a number. Since the parsing first happens in
`isNull` function and then again in `getLong`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
