capistrant commented on a change in pull request #10284:
URL: https://github.com/apache/druid/pull/10284#discussion_r546805619
##########
File path:
server/src/main/java/org/apache/druid/server/coordinator/CoordinatorDynamicConfig.java
##########
@@ -463,6 +485,7 @@ public Builder(
this.mergeBytesLimit = mergeBytesLimit;
this.mergeSegmentsLimit = mergeSegmentsLimit;
this.maxSegmentsToMove = maxSegmentsToMove;
+ this.percentOfSegmentsToConsiderPerMove =
percentOfSegmentsToConsiderPerMove;
Review comment:
hmm, Since this is a Builder class that builds a
CoordinatorDynamicConfig object, I think this precondition is covered by the
actual constructor for the CoordinatorDynamicConfig class. IMO, having another
precondition here is redundant
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
