capistrant edited a comment on pull request #10287: URL: https://github.com/apache/druid/pull/10287#issuecomment-749084418
> real numbers reported from #10603 might make this more obvious eventually. > > That said, On the surface, I do agree with your assessment of the utility of `LogUsedSegments` and understand why you would wanna remove it. That check appears to have existed since the beginning of [druid] time :) and not sure what original motivation was ... maybe there were bugs at the time and adding this check uncovered those and now a days it doesn't flag anything. > > I would set `druid.coordinator.logUsedSegments.enabled` default value to `false` and leave it undocumented for now. > > if, after a bunch of releases, nobody notices it then maybe remove that code altogether. Hmmm. If we are going to go with a disabled and undocumented implementation, I will add a design review label to make sure we get +1 from an extra committer. I do slightly question the removal because the debug logging may actually be useful for some people. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
