gianm commented on a change in pull request #10700: URL: https://github.com/apache/druid/pull/10700#discussion_r548340555
########## File path: server/src/main/java/org/apache/druid/discovery/NodeRole.java ########## @@ -31,33 +38,88 @@ * These abstractions can probably be merged when Druid updates to Jackson 2.9 that supports JsonAliases, see * see https://github.com/apache/druid/issues/7152. */ -public enum NodeRole +public class NodeRole Review comment: Please edit the javadoc: - It's no longer an enum, the the javadoc says it is. - The javadoc should explain the difference between "name" and "jsonName" and why they both exist. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
