jihoonson commented on pull request #10414: URL: https://github.com/apache/druid/pull/10414#issuecomment-754336574
Hi @T45K, `DataSegmentPusher.getDefaultStorageDirWithExistingUniquePath()` is used only by `ExportMetadata` which is a tool to export data from metadata store. Since all segments in the metadata store must not be `BucketNumberedShardSpec` (it's checked in `getDefaultStorageDir()` and other places :slightly_smiling_face:), this change doesn't seem necessary to me. I'm closing this PR, but please feel free to reopen if you think it's still useful. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
