abhishekagarwal87 commented on a change in pull request #10729:
URL: https://github.com/apache/druid/pull/10729#discussion_r551770859
##########
File path:
server/src/main/java/org/apache/druid/client/indexing/SamplerResponse.java
##########
@@ -58,6 +64,27 @@ public int getNumRowsIndexed()
return data;
}
+ @Override
+ public boolean equals(Object o)
+ {
+ if (this == o) {
+ return true;
+ }
+ if (o == null || getClass() != o.getClass()) {
+ return false;
+ }
+ SamplerResponse that = (SamplerResponse) o;
+ return getNumRowsRead() == that.getNumRowsRead() &&
+ getNumRowsIndexed() == that.getNumRowsIndexed() &&
+ Objects.equals(getData(), that.getData());
Review comment:
Never mind. I was thinking if, for some `List` implementations, the
`equals` may not have been implemented correctly. But that is unlikely to
happen. was also wondering if we care about the order too.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
