kaijianding commented on a change in pull request #10688:
URL: https://github.com/apache/druid/pull/10688#discussion_r552410763
##########
File path: server/src/main/java/org/apache/druid/server/SegmentManager.java
##########
@@ -219,9 +220,9 @@ private TableDataSource
getTableDataSource(DataSourceAnalysis analysis)
*
* @throws SegmentLoadingException if the segment cannot be loaded
*/
- public boolean loadSegment(final DataSegment segment, boolean lazy) throws
SegmentLoadingException
+ public boolean loadSegment(final DataSegment segment, boolean lazy,
CommonCallback loadFailed) throws SegmentLoadingException
Review comment:
add a new `@param` in the method comment
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
