xvrl commented on a change in pull request #10730:
URL: https://github.com/apache/druid/pull/10730#discussion_r553516275
##########
File path:
extensions-core/kinesis-indexing-service/src/main/java/org/apache/druid/indexing/kinesis/KinesisRecordSupplier.java
##########
@@ -296,14 +279,22 @@ private Runnable fetchRecords()
);
- log.trace(
- "Stream[%s] / partition[%s] / sequenceNum[%s] /
bufferRemainingCapacity[%d]: %s",
- currRecord.getStream(),
- currRecord.getPartitionId(),
- currRecord.getSequenceNumber(),
- records.remainingCapacity(),
-
currRecord.getData().stream().map(StringUtils::fromUtf8).collect(Collectors.toList())
Review comment:
I'm not even sure this is safe to do. Some byte arrays could technically
be invalid UTF-8 sequences, which would lead to exceptions when trying to log
values.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
