capistrant commented on a change in pull request #10287:
URL: https://github.com/apache/druid/pull/10287#discussion_r554117678
##########
File path:
server/src/main/java/org/apache/druid/server/coordinator/DruidCoordinator.java
##########
@@ -669,21 +669,31 @@ private void stopBeingLeader()
private List<CoordinatorDuty> makeHistoricalManagementDuties()
{
- return ImmutableList.of(
- new LogUsedSegments(),
+ List<CoordinatorDuty> duties = new ArrayList<>();
+ if (config.isLogUsedSegmentsDutyEnabled()) {
+ duties.add(new LogUsedSegments());
+ }
+ duties.addAll(ImmutableList.of(
new UpdateCoordinatorStateAndPrepareCluster(),
new RunRules(DruidCoordinator.this),
new UnloadUnusedSegments(),
new MarkAsUnusedOvershadowedSegments(DruidCoordinator.this),
new BalanceSegments(DruidCoordinator.this),
new EmitClusterStatsAndMetrics(DruidCoordinator.this)
+ ));
+ log.debug(
+ "Done making historical management duties %s",
+ duties.stream().map(duty ->
duty.getClass().getName()).collect(Collectors.toList())
);
+ return duties;
Review comment:
makeIndexingServiceDuties below used ImmutableList.copyOf(duties) so I
will stick with that for consistency
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
