nishantmonu51 commented on a change in pull request #10677:
URL: https://github.com/apache/druid/pull/10677#discussion_r555825958
##########
File path:
indexing-service/src/main/java/org/apache/druid/indexing/common/task/IndexTask.java
##########
@@ -1044,17 +1048,21 @@ public IndexIOConfig(
if (firehoseFactory != null && inputFormat != null) {
throw new IAE("Cannot use firehose and inputFormat together. Try using
inputSource instead of firehose.");
}
+ if (inputSource != null) {
+ inputSource.validateAllowDenyPrefixList(securityConfig);
Review comment:
isReady is also called multiple times, so not sure if that is any better
in terms of number of checks,
Just to double check, if i move it to isReady the task will be accepted by
the overlord and it will fail when the task is actually tried to be run. I was
thinking that if someone is not allowed, we should block the ingestion at that
time when the task is submitted at first place. Is that the behavior you are
expecting ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
