gianm commented on a change in pull request #10748:
URL: https://github.com/apache/druid/pull/10748#discussion_r556167558
##########
File path: docs/ingestion/native-batch.md
##########
@@ -192,7 +192,7 @@ that range if there's some stray data with unexpected
timestamps.
|--------|-----------|-------|---------|
|type|The task type, this should always be `index_parallel`.|none|yes|
|inputFormat|[`inputFormat`](./data-formats.md#input-format) to specify how to
parse input data.|none|yes|
-|appendToExisting|Creates segments as additional shards of the latest version,
effectively appending to the segment set instead of replacing it. The current
limitation is that you can append to any datasources regardless of their
original partitioning scheme, but the appended segments should be partitioned
using the `dynamic` partitionsSpec.|false|no|
+|appendToExisting|Creates segments as additional shards of the latest version,
effectively appending to the segment set instead of replacing it. This means
that you can append new segments to any datasource regardless of its original
partitioning scheme. However, you must use the `dynamic` partitioning type for
the appended segments .|false|no|
Review comment:
The doc should address what happens if you disregard this advice and set
appendToExisting: true but don't use dynamic partitioning. (Do you get an
error? Does something weird happen?)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@druid.apache.org
For additional commands, e-mail: commits-h...@druid.apache.org
