jihoonson commented on pull request #10746:
URL: https://github.com/apache/druid/pull/10746#issuecomment-759843464
```Diff coverage statistics:
------------------------------------------------------------------------------
| lines | branches | functions | path
------------------------------------------------------------------------------
| 100% (17/17) | 100% (0/0) | 92% (12/13) |
org/apache/druid/server/QueryResource.java
| 32% (11/34) | 44% (4/9) | 71% (27/38) |
org/apache/druid/client/JsonParserIterator.java
| 0% (0/1) | 100% (0/0) | 100% (1/1) |
org/apache/druid/client/DirectDruidClient.java
| 100% (3/3) | 100% (0/0) | 50% (2/4) |
org/apache/druid/server/security/SecuritySanityCheckFilter.java
| 100% (1/1) | 100% (0/0) | 66% (6/9) |
org/apache/druid/server/security/ForbiddenException.java
------------------------------------------------------------------------------
Total diff coverage:
- lines: 57% (32/56)
- branches: 44% (4/9)
- functions: 73% (48/65)
ERROR: Insufficient branch coverage of 44% (4/9). Required 50%.
```
The test coverage check failed. I agree those branches in
`JsonParserIterator` should be covered, but since this is blocking a branch
cut, I will add them as a follow-up. Other integration test failures seem
flaky. I just restarted them.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@druid.apache.org
For additional commands, e-mail: commits-h...@druid.apache.org
