himanshug edited a comment on issue #10752: URL: https://github.com/apache/druid/issues/10752#issuecomment-760547707
hey @jihoonson , I am very excited about `Service discovery and leader election based on Kubernetes` but I am in the process of writing a PR that runs #10680 for k8s based deployment to stress test the k8s based leader election mechanism ... In that process I found two improvements, (1) upgrade to newer version of `kubernetes-client` library which has some leader election improvements and makes leader changes happen quicker if a node is gracefully stopped (2) a bug which shows up in specific deployments where `druid.host` gets set to something more than 63 characters which is the max length limit on kubernetes label values I will address all of the above including introducing the new build in a new PR, those updates would make this feature a lot more robust and production ready. Thanks to @clintropolis for introducing #10680 which really stresses the overlord/coordinator startup, discovery, leader election machinery to help discover above improvements. that said, I think, 0.21.0 should continue to go on its schedule. For that reason, I think we should remove the mention of this new feature in 0.21.0 release notes and we can document its availability in next release. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
