loquisgon commented on a change in pull request #10742:
URL: https://github.com/apache/druid/pull/10742#discussion_r564678335
##########
File path:
indexing-service/src/main/java/org/apache/druid/indexing/common/task/AbstractBatchIndexTask.java
##########
@@ -373,23 +373,25 @@ private boolean
tryLockWithDetermineResult(TaskActionClient client, LockGranular
}
}
+
protected boolean tryTimeChunkLock(TaskActionClient client, List<Interval>
intervals) throws IOException
{
-
- // In this case, the intervals to lock must be aligned with
segmentGranularity if it's defined
- final Iterator<Interval> intervalIterator;
+ // The given intervals are first converted to align with segment
granularity. This is because,
+ // when an overwriting task finds a version for a given input row, it
expects the interval
+ // associated to each version to be equal or larger than the time bucket
where the input row falls in.
+ // See ParallelIndexSupervisorTask.findVersion().
+ final Set<Interval> uniqueCondensedIntervals = new HashSet<>();
final Granularity segmentGranularity = getSegmentGranularity();
if (segmentGranularity == null) {
- Set<Interval> uniqueIntervals = new HashSet<>(intervals);
- ArrayList<Interval> condensedIntervals = JodaUtils.condenseIntervals(()
-> uniqueIntervals.iterator());
- intervalIterator = condensedIntervals.iterator();
+ uniqueCondensedIntervals.addAll(JodaUtils.condenseIntervals(intervals));
} else {
IntervalsByGranularity intervalsByGranularity = new
IntervalsByGranularity(intervals, segmentGranularity);
- intervalIterator = intervalsByGranularity.granularityIntervalsIterator();
+ // the following is calling a condense that does not materialize the
intervals:
+
uniqueCondensedIntervals.addAll(JodaUtils.condenseIntervals(intervalsByGranularity.granularityIntervalsIterator()));
Review comment:
No need to write the new method that does not materialize intervals...
it is already done by the `JodaUtils` `condenseIntervals` method that takes an
iterator...
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
