jihoonson commented on a change in pull request #10833:
URL: https://github.com/apache/druid/pull/10833#discussion_r569072287
##########
File path:
processing/src/main/java/org/apache/druid/query/ResourceLimitExceededException.java
##########
@@ -35,9 +34,14 @@
{
public static final String ERROR_CODE = "Resource limit exceeded";
- public ResourceLimitExceededException(String message, Object... arguments)
+ public ResourceLimitExceededException(String message)
Review comment:
I made a mistake in my previous PR that creates a
`ResourceLimitExceededException` by calling `new
ResourceLimitExceededException(errorCode, message, errorClass, host)` which
actually calls `ResourceLimitExceededException(String message, Object...
arguments)`. I didn't notice my mistake until I add a test for it because
Intellij says you are cool. This change was to avoid such mistakes, but I agree
it is useful. I added a static constructor that does the same.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
