zhangyue19921010 commented on a change in pull request #10524:
URL: https://github.com/apache/druid/pull/10524#discussion_r569983870
##########
File path:
indexing-service/src/main/java/org/apache/druid/indexing/seekablestream/supervisor/SeekableStreamSupervisor.java
##########
@@ -519,20 +636,40 @@ public SeekableStreamSupervisor(
this.useExclusiveStartingSequence = useExclusiveStartingSequence;
this.dataSource = spec.getDataSchema().getDataSource();
this.ioConfig = spec.getIoConfig();
+ this.dynamicAllocationTasksProperties =
ioConfig.getDynamicAllocationTasksProperties();
Review comment:
Sure, It is a little strange that use map.getOrDefault() here, because
default value is hard to be unified.
I modified the way of obtaining configurations from Map to new interface
`AutoScalerConfig` with a default impl `DefaultAutoScaleConfig`. So that we can
use JackSon to Instantiate a Config with **default values** instead of
map.get/parse everywhere. **Also ensure consistency of default values.**
In this way, we don't need to get a handle to `SupervisorTaskAutoscaler`,
just `autoScalerConfig.getTaskCountMax()` :)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
