a2l007 commented on a change in pull request #10830:
URL: https://github.com/apache/druid/pull/10830#discussion_r573073247
##########
File path:
extensions-core/hdfs-storage/src/main/java/org/apache/druid/firehose/hdfs/HdfsFirehoseFactory.java
##########
@@ -44,21 +45,25 @@
{
private final List<String> inputPaths;
private final Configuration conf;
+ private final HdfsInputSourceConfig inputSourceConfig;
@JsonCreator
public HdfsFirehoseFactory(
- @JacksonInject @Hdfs Configuration conf,
@JsonProperty("paths") Object inputPaths,
@JsonProperty("maxCacheCapacityBytes") Long maxCacheCapacityBytes,
@JsonProperty("maxFetchCapacityBytes") Long maxFetchCapacityBytes,
@JsonProperty("prefetchTriggerBytes") Long prefetchTriggerBytes,
@JsonProperty("fetchTimeout") Long fetchTimeout,
- @JsonProperty("maxFetchRetry") Integer maxFetchRetry
+ @JsonProperty("maxFetchRetry") Integer maxFetchRetry,
+ @JacksonInject @Hdfs Configuration conf,
+ @JacksonInject HdfsInputSourceConfig inputSourceConfig
)
{
super(maxCacheCapacityBytes, maxFetchCapacityBytes, prefetchTriggerBytes,
fetchTimeout, maxFetchRetry);
- this.inputPaths = HdfsInputSource.coerceInputPathsToList(inputPaths,
"inputPaths");
+ this.inputPaths = HdfsInputSource.coerceInputPathsToList(inputPaths,
"paths");
Review comment:
👍
##########
File path: docs/ingestion/native-batch.md
##########
@@ -1064,7 +1064,7 @@ Sample specs:
"type": "index_parallel",
"inputSource": {
"type": "hdfs",
- "paths": "hdfs://foo/bar/", "hdfs://bar/foo"
+ "paths": "hdfs:/foo/bar/", "hdfs:/bar/foo"
Review comment:
nit: Is this change needed?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
