clintropolis commented on a change in pull request #10874:
URL: https://github.com/apache/druid/pull/10874#discussion_r574075733
##########
File path:
sql/src/main/java/org/apache/druid/sql/calcite/schema/InformationSchema.java
##########
@@ -119,12 +122,14 @@
private final Map<String, Table> tableMap;
private final AuthorizerMapper authorizerMapper;
private final String druidSchemaName;
+ private final String viewSchemaName;
@Inject
public InformationSchema(
@Named(DruidCalciteSchemaModule.INCOMPLETE_SCHEMA) final SchemaPlus
rootSchema,
final AuthorizerMapper authorizerMapper,
- @DruidSchemaName String druidSchemaName
+ @DruidSchemaName String druidSchemaName,
+ @ViewSchemaName String viewSchemaName
Review comment:
I guess `NamedViewSchema` should probably use this injected name instead
of its own name, and also `SqlResourceCollectorShuttle` should probably accept
it as well since it does for druid schema name.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
