kaijianding opened a new pull request #10899:
URL: https://github.com/apache/druid/pull/10899


   ### Description
   
   for a sql like this
   ```sql
   select count(1) as totalData
   from  (
      select count(distinct unique_user_id) as uv
      from a_table
      group by city_name
      order by uv
   ) t
   ```
   unique_user_id is hyperUnique metric.
   
   java.lang.ClassCastException is thrown as
   > java.lang.Long cannot be cast to java.lang.Double
   
   The reason is that  `count(distinct unique_user_id)` is Long in row 
signature, but the comparator in `HyperUniqueFinalizingPostAggregator` is Double
   
   <hr>
   
   This PR has:
   - [x] been self-reviewed.
      - [ ] using the [concurrency 
checklist](https://github.com/apache/druid/blob/master/dev/code-review/concurrency.md)
 (Remove this item if the PR doesn't have any relation to concurrency.)
   - [ ] added documentation for new or modified features or behaviors.
   - [ ] added Javadocs for most classes and all non-trivial methods. Linked 
related entities via Javadoc links.
   - [ ] added or updated version, license, or notice information in 
[licenses.yaml](https://github.com/apache/druid/blob/master/licenses.yaml)
   - [ ] added comments explaining the "why" and the intent of the code 
wherever would not be obvious for an unfamiliar reader.
   - [ ] added unit tests or modified existing tests to cover new code paths, 
ensuring the threshold for [code 
coverage](https://github.com/apache/druid/blob/master/dev/code-review/code-coverage.md)
 is met.
   - [ ] added integration tests.
   - [x] been tested in a test Druid cluster.
   
   <hr>
   
   ##### Key changed/added classes in this PR
    * `HyperUniqueFinalizingPostAggregator`
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to