clintropolis commented on a change in pull request #10891:
URL: https://github.com/apache/druid/pull/10891#discussion_r578850100



##########
File path: 
server/src/main/java/org/apache/druid/segment/realtime/appenderator/AppenderatorImpl.java
##########
@@ -332,6 +332,47 @@ public AppenderatorAddResult add(
       if (allowIncrementalPersists) {
         // persistAll clears rowsCurrentlyInMemory, no need to update it.
         log.info("Flushing in-memory data to disk because %s.", 
String.join(",", persistReasons));
+
+        long bytesPersisted = 0L;

Review comment:
       super nitpick, but this should probably be named `bytesToBePersisted` or 
something since it isn't actually persisted yet




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to