capistrant commented on a change in pull request #10524:
URL: https://github.com/apache/druid/pull/10524#discussion_r587908828
##########
File path: pom.xml
##########
@@ -957,6 +957,11 @@
<artifactId>jna</artifactId>
<version>4.5.1</version>
</dependency>
+ <dependency>
Review comment:
does this need to be added added to licesnses.yaml?
https://github.com/apache/druid/blob/master/dev/license.md#when-you-add-a-new-library-dependency-into-druid
##########
File path:
extensions-core/kafka-indexing-service/src/main/java/org/apache/druid/indexing/kafka/supervisor/KafkaSupervisorIOConfig.java
##########
@@ -51,6 +53,7 @@ public KafkaSupervisorIOConfig(
@JsonProperty("taskCount") Integer taskCount,
@JsonProperty("taskDuration") Period taskDuration,
@JsonProperty("consumerProperties") Map<String, Object>
consumerProperties,
+ @Nullable @JsonProperty("autoScalerConfig") AutoScalerConfig
autoScalerConfig,
Review comment:
Should this be included in toString below?
##########
File path:
extensions-core/kinesis-indexing-service/src/main/java/org/apache/druid/indexing/kinesis/supervisor/KinesisSupervisor.java
##########
@@ -378,6 +379,13 @@ protected boolean
useExclusiveStartSequenceNumberForNonFirstSequence()
return true;
}
+ // not yet supported, will be implemented in the future maybe? need to find
a proper way to measure kinesis lag.
+ @Override
+ public LagStats computeLagStats()
Review comment:
Not sure if UnsupportedOperationException would be better here or if
null is fine.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
