himanshug opened a new pull request #10961: URL: https://github.com/apache/druid/pull/10961
### Description Fixes a bug which shows up in specific deployments, that use k8s based discovery module, where `druid.host` gets set to something more than 63 characters which is the max length limit on kubernetes label values. Currently we put full `host:port` as a k8s label inside pod spec, which can be of arbitrary length. This patch changes node discovery mechanism to work with a hash of `host:port` in the label value instead. It is the (2) issue described in https://github.com/apache/druid/issues/10752#issuecomment-760547707 . Since this issue will be encountered by users quickly so hoping to have this included in 0.21.0 release. PS: Existing [unit/integration] tests cover the changes made here. It would further be exercised in a larger PR that introduces leader election improvements and integration tests similar to https://github.com/apache/druid/pull/10680 would be done later, that is blocked on a new release from kubernetes java client lib we use, that contains few leader election algorithm improvements. <hr> <!-- Check the items by putting "x" in the brackets for the done things. Not all of these items apply to every PR. Remove the items which are not done or not relevant to the PR. None of the items from the checklist below are strictly necessary, but it would be very helpful if you at least self-review the PR. --> This PR has: - [x] been self-reviewed. - [ ] using the [concurrency checklist](https://github.com/apache/druid/blob/master/dev/code-review/concurrency.md) (Remove this item if the PR doesn't have any relation to concurrency.) - [x] added documentation for new or modified features or behaviors. - [x] added Javadocs for most classes and all non-trivial methods. Linked related entities via Javadoc links. - [ ] added or updated version, license, or notice information in [licenses.yaml](https://github.com/apache/druid/blob/master/dev/license.md) - [ ] added comments explaining the "why" and the intent of the code wherever would not be obvious for an unfamiliar reader. - [x] added unit tests or modified existing tests to cover new code paths, ensuring the threshold for [code coverage](https://github.com/apache/druid/blob/master/dev/code-review/code-coverage.md) is met. - [ ] added integration tests. - [ ] been tested in a test Druid cluster. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
