maytasm commented on pull request #10962: URL: https://github.com/apache/druid/pull/10962#issuecomment-794393982
> > > Is it possible to add an integration test for this? Maybe update `SyntheticStreamGenerator#run` to send a null event a configurable number of times per run - then the tests can check how many parse exceptions were thrown. > > > I think a test like this can help flush out whether similar issues exist with other data formats... To be fair, I don't know why a null event would ever end up in a stream > > > > > > I think it is possible to add to the integration test but is not easy. For testing the JSON (this bug), i don't think the integration test would provide any additional coverage compare to `KafkaIndexTaskTest.java` and `KinesisIndexTaskTest.java `. For providing coverage for other other data formats, I don't think we have to do it now in this PR. This PR is only intended to fix the regression so I would like to keep the scope small. We can look into adding more integration tests for other data formats for various cases in a separate PR. > > This seems like a reasonable approach. Can you create a github issue for this - maybe label this with `Contributions Welcome` or `Starter` so people from the community can help fill this gap Done. https://github.com/apache/druid/issues/10971 ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
