clintropolis commented on a change in pull request #10968:
URL: https://github.com/apache/druid/pull/10968#discussion_r590778715
##########
File path:
sql/src/main/java/org/apache/druid/sql/calcite/filtration/CombineAndSimplifyBounds.java
##########
@@ -130,15 +134,24 @@ private static DimFilter doSimplify(final List<DimFilter>
children, boolean disj
// Group Bound filters by dimension, extractionFn, and comparator and
compute a RangeSet for each one.
final Map<BoundRefKey, List<BoundDimFilter>> bounds = new HashMap<>();
+ boolean allFalse = true;
Review comment:
Actually, I lied, `AndDimFilter` and `OrDimFilter` cannot be created
without at least 1 child, so added a comment stating this as the case
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
