clintropolis commented on a change in pull request #10948:
URL: https://github.com/apache/druid/pull/10948#discussion_r596410264
##########
File path: processing/src/main/java/org/apache/druid/segment/IndexMerger.java
##########
@@ -106,6 +118,41 @@
return null;
}
+ if (isDimensionOrderingValid(indexes, orderingCandidate)) {
+ return ImmutableList.copyOf(orderingCandidate);
+ } else {
+ log.info("Indexes have incompatible dimension orders, try falling back
on dimension ordering from ingestionSpec");
+ // Check if there is a valid dimension ordering in the ingestionSpec to
fall back on
+ if (dimensionsSpec == null ||
CollectionUtils.isNullOrEmpty(dimensionsSpec.getDimensionNames())) {
+ log.info("Cannot fall back on dimension ordering from ingestionSpec as
it does not exist");
+ return null;
+ }
+ List<String> candidate = dimensionsSpec.getDimensionNames();
Review comment:
should this be a copy?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
