clintropolis commented on a change in pull request #11004:
URL: https://github.com/apache/druid/pull/11004#discussion_r597393807
##########
File path:
processing/src/test/java/org/apache/druid/segment/data/VSizeLongSerdeTest.java
##########
@@ -20,132 +20,352 @@
package org.apache.druid.segment.data;
+import com.google.common.primitives.Ints;
+import org.apache.druid.java.util.common.StringUtils;
import org.junit.Assert;
-import org.junit.Before;
import org.junit.Test;
+import org.junit.experimental.runners.Enclosed;
+import org.junit.runner.RunWith;
+import org.junit.runners.Parameterized;
import java.io.ByteArrayOutputStream;
import java.io.IOException;
import java.nio.ByteBuffer;
+import java.util.Arrays;
+import java.util.Collection;
+import java.util.stream.Collectors;
+@RunWith(Enclosed.class)
public class VSizeLongSerdeTest
Review comment:
oops, preconditions broke test for 64 bit `testEveryPowerOfTwo`, which
overflows, though thinking about it, I guess it wouldn't matter if 64 is
negative because it has all the bits. I've made an exception for this case to
make this test pass again.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
