samarthjain commented on a change in pull request #11013:
URL: https://github.com/apache/druid/pull/11013#discussion_r597458727
##########
File path:
server/src/main/java/org/apache/druid/server/security/AuthorizationUtils.java
##########
@@ -263,10 +263,6 @@ public static Access authorizeAllResourceActions(
throw new ISE("No authorizer found with name: [%s].",
authenticationResult.getAuthorizerName());
}
- if (authorizer instanceof AllowAllAuthorizer) {
- return resources;
- }
-
Review comment:
Good call, @suneet-s . I added a unit test in the new commit and in the
process I found that we can still skip authorizing the resources when
AllowAllAuthorizer is configured.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
