clintropolis commented on a change in pull request #11018:
URL: https://github.com/apache/druid/pull/11018#discussion_r600143986
##########
File path:
extensions-core/protobuf-extensions/src/main/java/org/apache/druid/data/input/protobuf/ProtobufExtensionsModule.java
##########
@@ -37,7 +37,8 @@
return Collections.singletonList(
new SimpleModule("ProtobufInputRowParserModule")
.registerSubtypes(
- new NamedType(ProtobufInputRowParser.class, "protobuf")
+ new NamedType(ProtobufInputRowParser.class, "protobuf"),
+ new NamedType(ProtobufInputFormat.class, "protobuf_format")
Review comment:
I think this could just be `protobuf` the same as the parser name, since
they are separate interfaces
##########
File path:
extensions-core/protobuf-extensions/src/main/java/org/apache/druid/data/input/protobuf/ProtobufReader.java
##########
@@ -0,0 +1,88 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+package org.apache.druid.data.input.protobuf;
+
+import com.fasterxml.jackson.core.JsonProcessingException;
+import com.fasterxml.jackson.databind.JsonNode;
+import com.fasterxml.jackson.databind.ObjectMapper;
+import com.google.common.collect.Iterators;
+import com.google.protobuf.util.JsonFormat;
+import org.apache.commons.io.IOUtils;
+import org.apache.druid.data.input.InputEntity;
+import org.apache.druid.data.input.InputRow;
+import org.apache.druid.data.input.InputRowSchema;
+import org.apache.druid.data.input.IntermediateRowParsingReader;
+import org.apache.druid.data.input.impl.MapInputRowParser;
+import org.apache.druid.java.util.common.CloseableIterators;
+import org.apache.druid.java.util.common.parsers.CloseableIterator;
+import org.apache.druid.java.util.common.parsers.JSONFlattenerMaker;
+import org.apache.druid.java.util.common.parsers.JSONPathSpec;
+import org.apache.druid.java.util.common.parsers.ObjectFlattener;
+import org.apache.druid.java.util.common.parsers.ObjectFlatteners;
+import org.apache.druid.java.util.common.parsers.ParseException;
+
+import java.io.IOException;
+import java.nio.ByteBuffer;
+import java.util.Collections;
+import java.util.List;
+import java.util.Map;
+
+public class ProtobufReader extends IntermediateRowParsingReader<String>
+{
+ private final InputRowSchema inputRowSchema;
+ private final InputEntity source;
+ private final ObjectFlattener<JsonNode> recordFlattener;
+ private final ProtobufBytesDecoder protobufBytesDecoder;
+
+ ProtobufReader(
+ InputRowSchema inputRowSchema,
+ InputEntity source,
+ ProtobufBytesDecoder protobufBytesDecoder,
+ JSONPathSpec flattenSpec
+ )
+ {
+ this.inputRowSchema = inputRowSchema;
+ this.source = source;
+ this.protobufBytesDecoder = protobufBytesDecoder;
+ this.recordFlattener = ObjectFlatteners.create(flattenSpec, new
JSONFlattenerMaker(true));
+ }
+
+ @Override
+ protected CloseableIterator<String> intermediateRowIterator() throws
IOException
+ {
+ return CloseableIterators.withEmptyBaggage(
+
Iterators.singletonIterator(JsonFormat.printer().print(protobufBytesDecoder.parse(ByteBuffer.wrap(IOUtils.toByteArray(source.open())))
+ )));
Review comment:
The `InputRowParser` implementation for protobuf has an optimization
that skips the conversion to JSON if a flattenSpec is not defined (see #9999),
since the overhead to convert to be able to flatten can slow input processing a
fair bit (from the numbers in that PR).
To retain this, it might make sense to make the intermediary format be
`ByteBuffer` or `byte[]`, and handle the case of having a `flattenSpec` or not
separately. I think these could probably be done within this same class, just
make `parseInputRows` behave differently for each situation, and it maybe makes
sense to use JSON conversion for the `toMap` method (it is by
`InputSourceSampler` for the sampler API).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
