pjain1 commented on a change in pull request #11026: URL: https://github.com/apache/druid/pull/11026#discussion_r602363449
########## File path: extensions-core/google-extensions/src/main/java/org/apache/druid/storage/google/GoogleTimestampVersionedDataFinder.java ########## @@ -0,0 +1,93 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +package org.apache.druid.storage.google; + +import com.google.api.services.storage.model.Objects; +import com.google.api.services.storage.model.StorageObject; +import com.google.inject.Inject; +import org.apache.druid.data.SearchableVersionedDataFinder; +import org.apache.druid.data.input.impl.CloudObjectLocation; +import org.apache.druid.java.util.common.StringUtils; + +import javax.annotation.Nullable; +import java.io.IOException; +import java.net.URI; +import java.util.regex.Pattern; + +public class GoogleTimestampVersionedDataFinder extends GoogleDataSegmentPuller + implements SearchableVersionedDataFinder<URI> +{ + private static final long MAX_LISTING_KEYS = 1000; + + @Inject + public GoogleTimestampVersionedDataFinder(final GoogleStorage storage) + { + super(storage); + } + + @Override + public URI getLatestVersion(URI descriptorBase, @Nullable Pattern pattern) + { + try { + long mostRecent = Long.MIN_VALUE; + URI latest = null; + final String bucket = descriptorBase.getAuthority(); + final String prefix = StringUtils.maybeRemoveLeadingSlash(descriptorBase.getPath()); + final Objects objects = storage.list(bucket).setPrefix(prefix).setMaxResults(MAX_LISTING_KEYS).execute(); + for (StorageObject storageObject : objects.getItems()) { + if (isDirectoryPlaceholder(storageObject)) { + continue; + } + // remove path prefix from file name + final CloudObjectLocation objectLocation = new CloudObjectLocation(storageObject.getBucket(), + storageObject.getName() + ); + final String keyString = StringUtils + .maybeRemoveLeadingSlash(storageObject.getName().substring(prefix.length())); + if (pattern != null && !pattern.matcher(keyString).matches()) { + continue; + } + final long latestModified = storageObject.getUpdated().getValue(); + if (latestModified >= mostRecent) { + mostRecent = latestModified; + latest = objectLocation.toUri(GoogleStorageDruidModule.SCHEME_GS); + } + } + return latest; + } + catch (IOException e) { + throw new RuntimeException(e); + } + } + + /** + * Similar to {@link org.apache.druid.storage.s3.ObjectSummaryIterator#isDirectoryPlaceholder} + * Copied to avoid creating dependency on s3 extensions + */ + private static boolean isDirectoryPlaceholder(final StorageObject storageObject) + { + // Recognize "standard" directory place-holder indications + if (storageObject.getName().endsWith("/") && storageObject.getSize().intValue() == 0) { + return true; + } + // Recognize place-holder objects created by the Google Storage console or S3 Organizer Firefox extension. + return storageObject.getName().endsWith("_$folder$") && storageObject.getSize().intValue() == 0; + } Review comment: moved to `GoogleUtils` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
