nishantmonu51 commented on a change in pull request #10995:
URL: https://github.com/apache/druid/pull/10995#discussion_r603542932
##########
File path:
extensions-core/s3-extensions/src/main/java/org/apache/druid/data/input/s3/S3InputSourceConfig.java
##########
@@ -34,24 +34,44 @@
*/
public class S3InputSourceConfig
{
+ @Nullable
+ @JsonProperty
+ private String assumeRoleArn;
+ @Nullable
+ @JsonProperty
+ private String assumeRoleExternalId;
+ @JsonProperty
+ private PasswordProvider accessKeyId;
+ @JsonProperty
+ private PasswordProvider secretAccessKey;
Review comment:
accessKeyId and SecretAccessKey are also nullable, Can we add annotation
these as well.
##########
File path: docs/ingestion/native-batch.md
##########
@@ -862,6 +862,47 @@ Sample specs:
...
```
+```json
+...
+ "ioConfig": {
+ "type": "index_parallel",
+ "inputSource": {
+ "type": "s3",
+ "uris": ["s3://foo/bar/file.json", "s3://bar/foo/file2.json"],
+ "properties": {
+ "accessKeyId": "KLJ78979SDFdS2",
+ "secretAccessKey": "KLS89s98sKJHKJKJH8721lljkd"
+ }
+ },
+ "inputFormat": {
+ "type": "json"
+ },
+ ...
+ },
+...
+```
+
+```json
+...
+ "ioConfig": {
+ "type": "index_parallel",
+ "inputSource": {
+ "type": "s3",
+ "uris": ["s3://foo/bar/file.json", "s3://bar/foo/file2.json"],
+ "properties": {
+ "accessKeyId": "KLJ78979SDFdS2",
+ "secretAccessKey": "KLS89s98sKJHKJKJH8721lljkd",
+ "assumeRoleArn": "arn:aws:iam::2981002874992:role/role-s3"
Review comment:
I believe above are some dummy IDs and roles and not some actual ones.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
