suneet-s commented on a change in pull request #11021:
URL: https://github.com/apache/druid/pull/11021#discussion_r609222083
##########
File path:
extensions-core/datasketches/src/main/java/org/apache/druid/query/aggregation/datasketches/theta/SketchAggregator.java
##########
@@ -112,7 +112,7 @@ static void updateUnion(Union union, Object update)
} else if (update instanceof byte[]) {
union.update((byte[]) update);
} else if (update instanceof Double) {
- union.update(((Double) update));
+ union.update((Double) update);
} else if (update instanceof Integer || update instanceof Long) {
union.update(((Number) update).longValue());
Review comment:
You are correct, there are no extra parenthesis here. Sorry about that.
CI is complaining because of missing tests for this Aggregator. Do you think
you could take a stab at adding some unit tests for this class?
https://github.com/apache/druid/blob/master/dev/intellij-setup.md#Set-Code-Coverage-Runner
documents how to run code coverage locally, so you can see which parts of the
class are being tested. The unit tests appear to be in `SketchAggregationTest`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
