capistrant commented on pull request #10877: URL: https://github.com/apache/druid/pull/10877#issuecomment-816122195
> I have not read the change yet, but thought about what you've mentioned in the PR description. > > What do you think of following a similar pattern to what we do for json config properties. Essentially, introduce a new config property with the new default of `PT0S`. And add code that validates the config that only one of the old and new property are set so that we can resolve this behavior. This way, operators can opt in to the functionality you're providing here without being forced to make a config change on an upgrade - just food for thought... > > I will try to look into this over the next 2 weeks I appreciate the feedback! I made some changes to better reflect the way things work today. I did not create a new config, but I changed the default of this config to be `null`. `null` is invalid and will cause an exception, like the negative Duration does in master today. This way, when an operator turns on kill for the first time, they will have the same experience as they do today if they do not explicitly add the `durationToRetain` config. Current users of the kill features will also see no difference since they have already added their explicit override of the config which will behave the same with my code as it currently does in master. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
