maytasm commented on a change in pull request #11078:
URL: https://github.com/apache/druid/pull/11078#discussion_r610286469
##########
File path:
server/src/main/java/org/apache/druid/server/audit/SQLAuditManagerConfig.java
##########
@@ -31,6 +31,9 @@
@JsonProperty
private boolean includePayloadAsDimensionInMetric = false;
+ @JsonProperty
+ private long maxPayloadSizeBytes = -1;
Review comment:
@jihoonson Ah, I was wrong. `HumanReadableBytes` does allow `-1`. For
example, CaffeineCacheConfig's sizeInBytes also uses `HumanReadableBytes` and
set default to `-1`. Changed this to use `HumanReadableBytes`. However, I kept
the default value as `-1` which is use for disabling the check. This is
consistent with a few other configs we have in Druid right now. We can discuss
on changing all of the configs and standardize disable/enable in a separate PR.
@FrankChen021 Negative values should not be set by the user. We can set it
to `-1` in the code for disabling the check and if user set it (which is to
enable it), then it must be set to a positive number.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
