FrankChen021 opened a new pull request #11127:
URL: https://github.com/apache/druid/pull/11127
### Description
#10786 Introduced an environment variable `ZK_VERSION` in
`docker-compose.base.yml` and this env variable is set to `3.5` in pom.xml of
integration-test module and the travis file `.travis.yml` .
In the README of integration-test module, there's a section describing how
to manually bring up Druid cluster by docker-compose. And because of lacking of
description that `ZK_VERSION` must be set, following the steps in that section
leads to failure of starting up `druid-zookeeper-kafka` service.
Of course one way to solve that problem is by updating the README to add a
step to tell users to set ZK_VERSION before manually bringing up Druid cluster.
But I think it's not friendly for users to do this because ZK_VERSION is an
interval environment variable mainly for backward compatibility and not a
variable exposed to users.
So, I make a slight change to the compose file to set the default value of
ZK_VERSION to 3.5, so that users don't care about setting this value.
- If ZK_VERSION is not set by shell environment variable, it will default to
3.5
- If ZK_VERSION is set by shell environment variable, it will use the value
set by shell
Such behaviors are compatible with current ways.
Since the default value of ZK_VERSION is set in compose file, I also remove
zk.version property from pom.xml in integration-test module to simply the
management of default version.
This PR has:
- [X] been self-reviewed.
- [ ] using the [concurrency
checklist](https://github.com/apache/druid/blob/master/dev/code-review/concurrency.md)
(Remove this item if the PR doesn't have any relation to concurrency.)
- [ ] added documentation for new or modified features or behaviors.
- [ ] added Javadocs for most classes and all non-trivial methods. Linked
related entities via Javadoc links.
- [ ] added or updated version, license, or notice information in
[licenses.yaml](https://github.com/apache/druid/blob/master/dev/license.md)
- [ ] added comments explaining the "why" and the intent of the code
wherever would not be obvious for an unfamiliar reader.
- [ ] added unit tests or modified existing tests to cover new code paths,
ensuring the threshold for [code
coverage](https://github.com/apache/druid/blob/master/dev/code-review/code-coverage.md)
is met.
- [ ] added integration tests.
- [ ] been tested in a test Druid cluster.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
