liran-funaro commented on pull request #11124: URL: https://github.com/apache/druid/pull/11124#issuecomment-823177125
> I added an "unused" suppression to the stuff in IncrementalIndex that is unused now, but that #10001 may need. You can avoid using "unused" annotation by allowing `AggregatorType[] aggs` to be defined as `protected`. This might be a more straightforward approach. I can rebase #10001 after this PR will be merged. Or alternatively, if you prefer to merge #10001 before this PR, I can modify `aggs` to be protected in #10001. Then you won't have to deal with this at all in this PR. Please let me know what you think. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
