clintropolis opened a new pull request #11146:
URL: https://github.com/apache/druid/pull/11146
Fixes #10207.
### Description
This extension was implementing `AggregatorFactory.getCombiningFactory` in
the base class `TimestampAggregatorFactory` which would create a new
`TimestampAggregatorFactory`, instead of a `TimestampMaxAggregatorFactory` or
`TimestampMinAggregatorFactory`. This meant the combining factory would create
a type that was no longer round trip serializable, causing the issue reported
in #10207.
This PR fixes this by making `TimestampAggregatorFactory` abstract, and
implementing this method directly in the min and max agg factories. I also
cleaned up equals/hashcode which were missing the format arguments, added
`@Nullable` annotations to things which looked like they could be null (I
decided this includes `fieldName` since `timestampSpec` uses the default time
column if it is null), switched to using `CacheKeyBuilder` (and added format
since was missing from cache key).
<hr>
This PR has:
- [ ] been self-reviewed.
- [ ] using the [concurrency
checklist](https://github.com/apache/druid/blob/master/dev/code-review/concurrency.md)
(Remove this item if the PR doesn't have any relation to concurrency.)
- [ ] added documentation for new or modified features or behaviors.
- [ ] added Javadocs for most classes and all non-trivial methods. Linked
related entities via Javadoc links.
- [ ] added or updated version, license, or notice information in
[licenses.yaml](https://github.com/apache/druid/blob/master/dev/license.md)
- [ ] added comments explaining the "why" and the intent of the code
wherever would not be obvious for an unfamiliar reader.
- [ ] added unit tests or modified existing tests to cover new code paths,
ensuring the threshold for [code
coverage](https://github.com/apache/druid/blob/master/dev/code-review/code-coverage.md)
is met.
- [ ] added integration tests.
- [ ] been tested in a test Druid cluster.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
