clintropolis commented on a change in pull request #11158:
URL: https://github.com/apache/druid/pull/11158#discussion_r619561788
##########
File path:
web-console/src/views/query-view/query-extra-info/query-extra-info.tsx
##########
@@ -39,20 +39,29 @@ import './query-extra-info.scss';
export interface QueryExtraInfoProps {
queryResult: QueryResult;
onDownload: (filename: string, format: string) => void;
+ onLoadMore: () => void;
}
export const QueryExtraInfo = React.memo(function QueryExtraInfo(props:
QueryExtraInfoProps) {
- const { queryResult, onDownload } = props;
+ const { queryResult, onDownload, onLoadMore } = props;
+ const wrapQueryLimit = queryResult.getSqlOuterLimit();
+ const hasMoreResults = queryResult.getNumResults() === wrapQueryLimit;
- function handleQueryInfoClick() {
- const id = queryResult.queryId || queryResult.sqlQueryId;
- if (!id) return;
+ function handleQueryInfoClick(e: MouseEvent<HTMLDivElement>) {
+ if (e.altKey) {
+ if (hasMoreResults) {
+ onLoadMore();
+ }
Review comment:
what does this do? something with limit wrapping or.. loading stuff? ...
if i followed correctly back to `handleLoadMore`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
