xvrl commented on a change in pull request #11167:
URL: https://github.com/apache/druid/pull/11167#discussion_r622393236
##########
File path: distribution/docker/Dockerfile
##########
@@ -47,12 +47,13 @@ RUN ["/busybox/busybox", "--install", "/bin"]
RUN addgroup -S -g 1000 druid \
&& adduser -S -u 1000 -D -H -h /opt/druid -s /bin/sh -g '' -G druid druid \
- && mkdir -p /opt/druid/var \
- && chown -R druid:druid /opt \
- && chmod 775 /opt/druid/var
+ && mkdir -p /opt
COPY --chown=druid:druid --from=builder /opt /opt
COPY distribution/docker/druid.sh /druid.sh
+RUN mkdir -p /opt/druid/var \
Review comment:
nit, I would remove the `-p` to ensure `/opt/druid` exists and symlinks
to a valid directory. When I did some testing, I realized that Docker for Mac
gets confused when copying from the builder stage if `/opt/druid` is already
created beforehand as a directory, causing it to fail to create the symlink.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
