gianm commented on a change in pull request #11170:
URL: https://github.com/apache/druid/pull/11170#discussion_r624059586
##########
File path:
processing/src/main/java/org/apache/druid/segment/virtual/SingleLongInputCachingExpressionColumnValueSelector.java
##########
@@ -46,7 +47,8 @@
private final LruEvalCache lruEvalCache;
// Last read input value.
- private long lastInput;
+ @Nullable
+ private Long lastInput;
Review comment:
This is going to involve boxing; I think it'd be more GC friendly to use
a `long` for lastInput + a `boolean` for lastInputIsNull.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
