maytasm commented on a change in pull request #11200:
URL: https://github.com/apache/druid/pull/11200#discussion_r627094355



##########
File path: docs/configuration/index.md
##########
@@ -747,6 +747,9 @@ These Coordinator static configurations can be defined in 
the `coordinator/runti
 |Property|Description|Required?|Default|
 |--------|-----------|---------|-------|
 |`druid.coordinator.period.metadataStoreManagementPeriod`|How often to run 
metadata management tasks in [ISO 8601](https://en.wikipedia.org/wiki/ISO_8601) 
duration format. |No | `PT1H`|
+|`druid.coordinator.kill.supervisor.on`| Boolean value for whether to enable 
automatic deletion of terminated supervisors. If set to true, Coordinator will 
periodically remove terminated supervisors from the supervisor table in 
metadata storage.| No | False| 
+|`druid.coordinator.kill.supervisor.period`| How often to do automatic 
deletion of terminated supervisor in [ISO 
8601](https://en.wikipedia.org/wiki/ISO_8601) duration format. Value must be 
greater than `druid.coordinator.period.metadataStoreManagementPeriod`. Only 
applies if `druid.coordinator.kill.supervisor.on` is set to True.| No| `P1D`|
+|`druid.coordinator.kill.supervisor.durationToRetain`| Duration of terminated 
supervisor to be retained from created time in [ISO 
8601](https://en.wikipedia.org/wiki/ISO_8601) duration format. Only applies if 
`druid.coordinator.kill.supervisor.on` is set to True.| Yes if 
`druid.coordinator.kill.supervisor.on` is set to True| None|

Review comment:
       The default in the code is used to fail cluster startup if the value is 
not set by the user. Basically code check for the value being positive (meaning 
that the user must set it and override the default value). For documentation 
simplicity sake, the default value in the code is the same effect as None and 
that the user must set the value. 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to