bananaaggle commented on pull request #11224: URL: https://github.com/apache/druid/pull/11224#issuecomment-835696627
> @bananaaggle I have invited you as a collaborator to my fork. I think my branch is currently a little more complete. > Should credit @rueian as I adapted some of their code as a starting point for my implementation. > > The main things left to do are implement tests and do some real world testing. I think we can spin up in-process Pulsar clusters to do this similar to how testing is done in https://github.com/streamnative/mop and https://github.com/streamnative/kop which should allow for fairly robust tests. > > Also need to work out correct place for the extension to live, I put it in extensions-core for now but perhaps it belongs in extensions-contrib? > > It also isn't clear where `PulsarSchemaRegistryAvroBytesDecoder` should live, it could either live in `avro-extensions` as it does now or could be put in `pulsar-indexing-service`. I think PulsarSchemaRegistryAvroBytesDecoder should be separated into another commit. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@druid.apache.org For additional commands, e-mail: commits-h...@druid.apache.org
