JulianJaffePinterest commented on a change in pull request #10920: URL: https://github.com/apache/druid/pull/10920#discussion_r640373936
########## File path: extensions-core/spark-extensions/src/main/scala/org/apache/druid/spark/configuration/DruidConfigurationKeys.scala ########## @@ -0,0 +1,130 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +package org.apache.druid.spark.configuration + +import org.apache.spark.sql.sources.v2.DataSourceOptions + +object DruidConfigurationKeys { + // Shadowing DataSourceOptions.TABLE_KEY here so other classes won't need unnecessary imports + val tableKey: String = DataSourceOptions.TABLE_KEY + + // Metadata Client Configs + val metadataPrefix: String = "metadata" + val metadataDbTypeKey: String = "dbType" + val metadataHostKey: String = "host" + val metadataPortKey: String = "port" + val metadataConnectUriKey: String = "connectUri" + val metadataUserKey: String = "user" + val metadataPasswordKey: String = "password" + val metadataDbcpPropertiesKey: String = "dbcpProperties" + val metadataBaseNameKey: String = "baseName" + private[spark] val metadataHostDefaultKey: (String, String) = (metadataHostKey, "localhost") + private[spark] val metadataPortDefaultKey: (String, Int) = (metadataPortKey, 1527) + private[spark] val metadataBaseNameDefaultKey: (String, String) = (metadataBaseNameKey, "druid") + + // Druid Client Configs + val brokerPrefix: String = "broker" + val brokerHostKey: String = "host" + val brokerPortKey: String = "port" + private[spark] val brokerHostDefaultKey: (String, String) = (brokerHostKey, "localhost") + private[spark] val brokerPortDefaultKey: (String, Int) = (brokerPortKey, 8082) + + // Common configs + val useCompactSketchesKey: String = "useCompactSketches" // Default: false Review comment: To allows users to work with compact versions of ThetaSketches if desired (for example, if they don't need to update the sketches after reading them) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
