suneet-s commented on pull request #11262: URL: https://github.com/apache/druid/pull/11262#issuecomment-850120524
> > Travis seems to be failing on spellcheck for pull-deps and I can't figure out why, it seems like this is used in other files without a problem. 🤔 > > The .spelling file is sort of funny, the top of the file is like global suppressions, then below that there are page specific suppressions, which I'm not quite certain why they need to exist (do we need some things to be spelling errors on some pages but not on others), but explains why it was failing here, since pull-deps is suppressed in `docs/development/extensions.md` and `docs/development/extensions-contrib/redis-cache.md` (funny enough not in `docs/operations/pull-deps.md` which always refers to it with back ticks) HA! that explains it. I don't think we need to make `pull-deps` a global suppression in this PR, so this change is good to go as is for me, although I wouldn't be opposed to a global `pull-deps` suppression either. @FrankChen021 I'll leave it to you to press the merge button for when you're happy with the change -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
