xvrl commented on a change in pull request #11299: URL: https://github.com/apache/druid/pull/11299#discussion_r641291832
########## File path: docs/tutorials/docker.md ########## @@ -36,7 +36,11 @@ The Druid source code contains [an example `docker-compose.yml`](https://github. ### Compose file -The example `docker-compose.yml` will create a container for each Druid service, as well as Zookeeper and a PostgreSQL container as the metadata store. Deep storage will be a local directory, by default configured as `./storage` relative to your `docker-compose.yml` file, and will be mounted as `/opt/data` and shared between Druid containers which require access to deep storage. The Druid containers are configured via an [environment file](https://github.com/apache/druid/blob/{{DRUIDVERSION}}/distribution/docker/environment). +The example `docker-compose.yml` will create a container for each Druid service, as well as Zookeeper and a PostgreSQL container as the metadata store. + +It will also create a named volumes `druid-data`, which is mounted as `opt/data` in container, as deep storage to keep and share segments and task logs among Druid services. Review comment: I feel `druid-data` and `/opt/data` is a little generic and doesn't really convey the idea that this is meant for shared storage. `/opt/druid/var` is also used for local "data" so the distinction is not very clear. Maybe we should give it a more descriptive name such as `/opt/shared`, or something else if you have better suggestions, wdyt? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
