jon-wei commented on a change in pull request #11316:
URL: https://github.com/apache/druid/pull/11316#discussion_r643326054
##########
File path:
indexing-service/src/main/java/org/apache/druid/indexing/common/task/HadoopIndexTask.java
##########
@@ -550,13 +545,8 @@ private void renameSegmentIndexFilesJob(
String dataSegmentAndIndexZipFilePathListStr
)
{
- final ClassLoader oldLoader =
Thread.currentThread().getContextClassLoader();
+ final ClassLoader loader = Thread.currentThread().getContextClassLoader();
try {
- ClassLoader loader = HadoopTask.buildClassLoader(
- getHadoopDependencyCoordinates(),
- taskConfig.getDefaultHadoopCoordinates()
- );
-
Object renameSegmentIndexFilesRunner = getForeignClassloaderObject(
Review comment:
It already builds a hadoopy classloader on line 320, which is the
current classloader in this context:
https://github.com/apache/druid/pull/11316/files#diff-2dcdadad4e69316f4771828f0d6b63e83f9735a56cf21881e81e4aa72296b11bR320
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
