wjhypo commented on a change in pull request #11307:
URL: https://github.com/apache/druid/pull/11307#discussion_r645979759
##########
File path:
processing/src/main/java/org/apache/druid/segment/QueryableIndexStorageAdapter.java
##########
@@ -270,7 +270,8 @@ public VectorCursor makeVectorCursor(
VirtualColumns virtualColumns,
Granularity gran,
boolean descending,
- @Nullable QueryMetrics<?> queryMetrics
+ @Nullable QueryMetrics<?> queryMetrics,
+ boolean useInMemoryBitmapInQuery
Review comment:
Hi Frank, this case is caused by `IncrementalIndexStorageAdapter` and
`QueryableIndexStorageAdapter` extending the same interface and lots of other
classes implementing the same interface introduced changes accordingly as well.
However, based on the previous discussion on the necessity of
`useInMemoryBitmapInQuery`, this param probably can be omitted and just use
`enableInMemoryBitmap` as the only switch, let me remove this param and
simplify the code.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
