bananaaggle commented on pull request #11240: URL: https://github.com/apache/druid/pull/11240#issuecomment-855858784
> I don't know whether there are some guys in the community who know much about RocketMQ, but as this extension follows the architecture of existing SeekableStreamXXX , the review may not require deep understanding of RocketMQ. > > To help review, could you: > > 1. add some descriptions of the differences in the implementations between the new RocketMQ indexing service and the Kafka indexing service > 2. and add the user doc about how people use this extension ? > > I would like take a look at the doc first. Thanks. Thank you very much for reviewing! RocketMQ indexing service is very similar with Kafka indexing service. I use DefaultLitePullConsumer in RocketMQ client, it has some same functions as Kafka client, such as seek , seekToLatest and so on. The main different between them is RocketMQ has no conception as partition. Messages are ordered in a queue on RocketMQ broker, so I use broker name + queueID as partition. It means partition is type of int in Kafka and string in RocketMQ. And other parts in remaining are very similar in those two extensions. Actually, I learnt something about SeekableStreamSupervisor last month. If some one wants to adapt to other extensions, the components need some necessary features. At first, message must be stored in ordered and partitioned. Secondly, it supports seek to specific offset. Only Pulsar and RocketMQ satisfy requirement. ActiveMQ/RabbitMQ/ZeroMQ/Redis can be integrated with SeekableStreamSupervisor because they have poorly Sub/Pub feature. Pravega has elastic segments so does not satisfy requirement. Above is background of this extension. Do you need some other descriptions? Where should I add descriptions, in code or in this page? As for documents, I will add it soon. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
