FrankChen021 commented on a change in pull request #11240: URL: https://github.com/apache/druid/pull/11240#discussion_r647447535
########## File path: extensions-contrib/rocketmq-indexing-service/src/main/java/org/apache/druid/indexing/rocketmq/RocketMQIndexTaskIOConfig.java ########## @@ -0,0 +1,174 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +package org.apache.druid.indexing.rocketmq; + +import com.fasterxml.jackson.annotation.JsonCreator; +import com.fasterxml.jackson.annotation.JsonProperty; +import com.google.common.base.Preconditions; +import org.apache.druid.data.input.InputFormat; +import org.apache.druid.indexing.rocketmq.supervisor.RocketMQSupervisorIOConfig; +import org.apache.druid.indexing.seekablestream.SeekableStreamEndSequenceNumbers; +import org.apache.druid.indexing.seekablestream.SeekableStreamIndexTaskIOConfig; +import org.apache.druid.indexing.seekablestream.SeekableStreamStartSequenceNumbers; +import org.joda.time.DateTime; + +import javax.annotation.Nullable; +import java.util.Map; + +public class RocketMQIndexTaskIOConfig extends SeekableStreamIndexTaskIOConfig<String, Long> +{ + private final Map<String, Object> consumerProperties; + private final long pollTimeout; + + @JsonCreator + public RocketMQIndexTaskIOConfig( + @JsonProperty("taskGroupId") @Nullable Integer taskGroupId, // can be null for backward compabitility + @JsonProperty("baseSequenceName") String baseSequenceName, + // startPartitions and endPartitions exist to be able to read old ioConfigs in metadata store + @JsonProperty("startPartitions") @Nullable + @Deprecated SeekableStreamEndSequenceNumbers<String, Long> startPartitions, + @JsonProperty("endPartitions") @Nullable + @Deprecated SeekableStreamEndSequenceNumbers<String, Long> endPartitions, + // startSequenceNumbers and endSequenceNumbers must be set for new versions + @JsonProperty("startSequenceNumbers") + @Nullable SeekableStreamStartSequenceNumbers<String, Long> startSequenceNumbers, + @JsonProperty("endSequenceNumbers") + @Nullable SeekableStreamEndSequenceNumbers<String, Long> endSequenceNumbers, + @JsonProperty("consumerProperties") Map<String, Object> consumerProperties, + @JsonProperty("pollTimeout") Long pollTimeout, + @JsonProperty("useTransaction") Boolean useTransaction, + @JsonProperty("minimumMessageTime") DateTime minimumMessageTime, + @JsonProperty("maximumMessageTime") DateTime maximumMessageTime, + @JsonProperty("inputFormat") @Nullable InputFormat inputFormat + ) + { + super( + taskGroupId, + baseSequenceName, + startSequenceNumbers == null + ? Preconditions.checkNotNull(startPartitions, "startPartitions").asStartPartitions(true) + : startSequenceNumbers, + endSequenceNumbers == null ? endPartitions : endSequenceNumbers, + useTransaction, + minimumMessageTime, + maximumMessageTime, + inputFormat + ); + + this.consumerProperties = Preconditions.checkNotNull(consumerProperties, "consumerProperties"); + this.pollTimeout = pollTimeout != null ? pollTimeout : RocketMQSupervisorIOConfig.DEFAULT_POLL_TIMEOUT_MILLIS; + + final SeekableStreamEndSequenceNumbers<String, Long> myEndSequenceNumbers = getEndSequenceNumbers(); + for (String partition : myEndSequenceNumbers.getPartitionSequenceNumberMap().keySet()) { + Preconditions.checkArgument( + myEndSequenceNumbers.getPartitionSequenceNumberMap() + .get(partition) + .compareTo(getStartSequenceNumbers().getPartitionSequenceNumberMap().get(partition)) >= 0, + "end offset must be >= start offset for partition[%s]", + partition + ); + } + } + + public RocketMQIndexTaskIOConfig( + int taskGroupId, + String baseSequenceName, + SeekableStreamStartSequenceNumbers<String, Long> startSequenceNumbers, + SeekableStreamEndSequenceNumbers<String, Long> endSequenceNumbers, + Map<String, Object> consumerProperties, + Long pollTimeout, + Boolean useTransaction, + DateTime minimumMessageTime, + DateTime maximumMessageTime, + InputFormat inputFormat + ) + { + this( + taskGroupId, + baseSequenceName, + null, + null, + startSequenceNumbers, + endSequenceNumbers, + consumerProperties, + pollTimeout, + useTransaction, + minimumMessageTime, + maximumMessageTime, + inputFormat + ); + } + + /** + * This method is for compatibilty so that newer version of RocketMQIndexTaskIOConfig can be read by + * old version of Druid. Note that this method returns end sequence numbers instead of start. This is because + * {@link SeekableStreamStartSequenceNumbers} didn't exist before. + */ + @JsonProperty + @Deprecated + public SeekableStreamEndSequenceNumbers<String, Long> getStartPartitions() + { + // Converting to start sequence numbers. This is allowed for RocketMQ because the start offset is always inclusive. + final SeekableStreamStartSequenceNumbers<String, Long> startSequenceNumbers = getStartSequenceNumbers(); + return new SeekableStreamEndSequenceNumbers<>( + startSequenceNumbers.getStream(), + startSequenceNumbers.getPartitionSequenceNumberMap() + ); + } + + /** + * This method is for compatibilty so that newer version of RocketMQIndexTaskIOConfig can be read by + * old version of Druid. + */ + @JsonProperty + @Deprecated + public SeekableStreamEndSequenceNumbers<String, Long> getEndPartitions() Review comment: The same as above -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
